fix: Login services button colors #32570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: bb30b5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32570 +/- ##
===========================================
- Coverage 56.85% 56.19% -0.67%
===========================================
Files 2498 2470 -28
Lines 55346 54900 -446
Branches 11416 11328 -88
===========================================
- Hits 31466 30850 -616
- Misses 21166 21381 +215
+ Partials 2714 2669 -45
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Jun 7, 2024
MarcosSpessatto
requested changes
Jun 10, 2024
|
Tested the change of button text setting in existing tests. |
But what about the issue? Isn't it about the color? 🤔 Didn't see anything mentioning the label.. |
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
dougfabris
requested changes
Jun 21, 2024
MarcosSpessatto
approved these changes
Jul 9, 2024
dionisio-bot
bot
added
the
stat: ready to merge
Merged
yash-rajpal
added a commit
that referenced
this pull request
Aug 1, 2024
This reverts commit 1566412.
yash-rajpal
added a commit
that referenced
this pull request
Sep 23, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 14, 2024
yash-rajpal
added a commit
that referenced
this pull request
Oct 15, 2024
yash-rajpal
added a commit
that referenced
this pull request
Oct 15, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 16, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The login services button was not implementing the button color properties, so fixed it and now the login services button will render the button colors as per the settings.
Issue(s)
Steps to test or reproduce
Further comments
SUP-590